Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ament_generate_version_header(..) to these packages? #1139

Closed
gavanderhoorn opened this issue Mar 25, 2024 · 1 comment · Fixed by #1141
Closed

Adding ament_generate_version_header(..) to these packages? #1139

gavanderhoorn opened this issue Mar 25, 2024 · 1 comment · Fixed by #1141

Comments

@gavanderhoorn
Copy link
Contributor

Feature request

Feature description

Would it be OK to add a call to ament_generate_version_header(..) to the CMakeLists.txt of the packages in this repository to allow dependent packages to check for specific (minimum) versions?

According to the Changelog this is supported since Humble, and would be of great use to packages which desire to conditionally compile specific code paths (avoid branching, etc).

AFAICT, only rclcpp currently exports that header (ros2/rclcpp#1886), so the suggestion is to add it to rcl (and a bunch of other core packages as well).

@gavanderhoorn
Copy link
Contributor Author

As I have other packages for which I'd like to use the macros defined in the version.h generated by ament_generate_version_header(..): would PRs against other core repositories also be welcome?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant