Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose rcl_remap_t in public API #254

Closed
sloretz opened this issue Jun 5, 2018 · 0 comments
Closed

Expose rcl_remap_t in public API #254

sloretz opened this issue Jun 5, 2018 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@sloretz
Copy link
Contributor

sloretz commented Jun 5, 2018

Feature request

The structure rcl_remap_t should be exposed in the public API, and maybe _rcl_parse_remap_rule() should be to.

Feature description

This is to allow it to be wrapped by rclcpp and passed into the node's constructor as something other than string arguments, which will allow ros2 launch to handle remap rules and parameter files the same way: parse arguments, decide which ones apply to which nodes, and pass just those args into the node's constructor.

Implementation considerations

  • remap.h will need to be installed
  • rcl_remap_t needs to use PIMPL pattern
  • maybe expose _rcl_parse_remap_rule() as a public function to allow creating a remap rule from one string
  • rcl_arguments_t needs a method to get remap rules
  • Could update rcl_remap_*() functions to accept a list of remap rules instead of an arguments struct since that's all they need.
@sloretz sloretz added the enhancement New feature or request label Jun 5, 2018
@cottsay cottsay added the ready Work is about to start (Kanban column) label Jan 24, 2019
@mjcarroll mjcarroll self-assigned this Jan 24, 2019
@mjcarroll mjcarroll added in progress Actively being worked on (Kanban column) and removed ready Work is about to start (Kanban column) labels Jan 24, 2019
@mjcarroll mjcarroll removed the in progress Actively being worked on (Kanban column) label Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants