Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace uses of reinterpret_cast with static_cast where possible #269

Closed
wjwwood opened this issue Jul 11, 2018 · 4 comments
Closed

replace uses of reinterpret_cast with static_cast where possible #269

wjwwood opened this issue Jul 11, 2018 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@wjwwood
Copy link
Member

wjwwood commented Jul 11, 2018

See: #261 (comment)
@wjwwood wjwwood added enhancement New feature or request help wanted Extra attention is needed labels Jul 11, 2018
@jhdcs
Copy link
Contributor

jhdcs commented Apr 1, 2019

I think I might have replaced a large chunk of the reinterpret_casts. I'm not 100% sure I trust the testing framework to catch any errors, but so far everything seems to be building correctly.

Want me to open a pull request?

@wjwwood
Copy link
Member Author

wjwwood commented Apr 1, 2019

Want me to open a pull request?

I would default to yes, pull requests can always be declined or refactored, and don't take much to open :)

@jhdcs jhdcs mentioned this issue Apr 1, 2019
Merged
@jhdcs
Copy link
Contributor

jhdcs commented Apr 1, 2019

Well, I still want to be polite ^_^

@sloretz
Copy link
Contributor

sloretz commented Apr 22, 2019

Fixed by #410

@sloretz sloretz closed this as completed Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wjwwood @sloretz @jhdcs