From 312cfecbbdbc7d482591cac73f03207fee1f9aa5 Mon Sep 17 00:00:00 2001 From: Mikael Arguedas Date: Tue, 29 Aug 2017 16:37:16 -0700 Subject: [PATCH] remove todo that doesnt seem necessary anymore --- rcl/test/rcl/test_publisher.cpp | 4 +--- rcl/test/rcl/test_subscription.cpp | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/rcl/test/rcl/test_publisher.cpp b/rcl/test/rcl/test_publisher.cpp index d62f1525e..a9fd06c22 100644 --- a/rcl/test/rcl/test_publisher.cpp +++ b/rcl/test/rcl/test_publisher.cpp @@ -127,9 +127,7 @@ TEST_F(CLASSNAME(TestPublisherFixture, RMW_IMPLEMENTATION), test_publisher_nomin std_msgs__msg__String__init(&msg); ASSERT_TRUE(rosidl_generator_c__String__assign(&msg.data, "testing")); ret = rcl_publish(&publisher, &msg); - // TODO(wjwwood): re-enable this fini when ownership of the string is resolved. - // currently with Connext we will spuriously get a double free here. - // std_msgs__msg__String__fini(&msg); + std_msgs__msg__String__fini(&msg); ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe(); } diff --git a/rcl/test/rcl/test_subscription.cpp b/rcl/test/rcl/test_subscription.cpp index 2a3ea9e70..fb5d72231 100644 --- a/rcl/test/rcl/test_subscription.cpp +++ b/rcl/test/rcl/test_subscription.cpp @@ -212,9 +212,7 @@ TEST_F(CLASSNAME(TestSubscriptionFixture, RMW_IMPLEMENTATION), test_subscription std_msgs__msg__String__init(&msg); ASSERT_TRUE(rosidl_generator_c__String__assign(&msg.data, test_string)); ret = rcl_publish(&publisher, &msg); - // TODO(wjwwood): re-enable this fini when ownership of the string is resolved. - // currently with Connext we will spuriously get a double free here. - // std_msgs__msg__String__fini(&msg); + std_msgs__msg__String__fini(&msg); ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe(); } bool success;