From 892e1f1021ee80578773ae541b2e3be3d6f31816 Mon Sep 17 00:00:00 2001 From: ivanpauno Date: Thu, 2 May 2019 10:22:26 -0300 Subject: [PATCH] Deprecate publish call taking a raw ptr. Stop deprecating publish methods in LifecyclePublisher. Signed-off-by: ivanpauno --- rclcpp/include/rclcpp/publisher.hpp | 2 ++ .../include/rclcpp_lifecycle/lifecycle_publisher.hpp | 3 --- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/rclcpp/include/rclcpp/publisher.hpp b/rclcpp/include/rclcpp/publisher.hpp index a9ecdb58c3..1242c15846 100644 --- a/rclcpp/include/rclcpp/publisher.hpp +++ b/rclcpp/include/rclcpp/publisher.hpp @@ -144,6 +144,8 @@ class Publisher : public PublisherBase this->publish(std::move(unique_msg)); } + [[deprecated( + "Use publish(*msg). Check against nullptr before calling if necessary.".)]] virtual void publish(const MessageT * msg) { diff --git a/rclcpp_lifecycle/include/rclcpp_lifecycle/lifecycle_publisher.hpp b/rclcpp_lifecycle/include/rclcpp_lifecycle/lifecycle_publisher.hpp index 115b87e15e..37389b5522 100644 --- a/rclcpp_lifecycle/include/rclcpp_lifecycle/lifecycle_publisher.hpp +++ b/rclcpp_lifecycle/include/rclcpp_lifecycle/lifecycle_publisher.hpp @@ -96,9 +96,6 @@ class LifecyclePublisher : public LifecyclePublisherInterface, * was enabled or disabled and forwards the message * to the actual rclcpp Publisher base class */ - [[deprecated( - "publishing an unique_ptr is prefered when using intra process communication." - " If using a shared_ptr, use publish(*msg).")]] virtual void publish(std::shared_ptr msg) {