Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows Inconsistent dll linkage with for_each_callback_group #1731

Closed
sloretz opened this issue Jul 28, 2021 · 0 comments · Fixed by #1732
Closed

Windows Inconsistent dll linkage with for_each_callback_group #1731

sloretz opened this issue Jul 28, 2021 · 0 comments · Fixed by #1732
Assignees
@sloretz

Comments

@sloretz
Copy link
Contributor

sloretz commented Jul 28, 2021

There's a new windows warning caused by #1723

'rclcpp_lifecycle::LifecycleNode::for_each_callback_group': inconsistent dll linkage

https://ci.ros2.org/job/ci_windows/15112/msbuild/

It was in the original CI too, but got overlooked because a flaky test also made the build yellow: http://ci.ros2.org/job/ci_windows/15092/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use RCLCPP_LIFECYCLE_PUBLIC visibility macro in rclcpp_lifecycle package ros2/rclcpp
1 participant
@sloretz