Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROS2] Missing lazy subscription headers #2060

Open
daisukes opened this issue Dec 9, 2022 · 3 comments
Open

[ROS2] Missing lazy subscription headers #2060

daisukes opened this issue Dec 9, 2022 · 3 comments
Labels

Comments

@daisukes
Copy link
Contributor

daisukes commented Dec 9, 2022

Feature request

Feature description

Implementation considerations

@SteveMacenski SteveMacenski changed the title Missing nodelet_topic_tools headers [ROS2] Missing lazy subscription headers Dec 9, 2022
@fujitatomoya
Copy link
Collaborator

@daisukes can you enlighten me more details about what the application want to do with example? i do not quite understand what is really required here...

this enhancement would enable us to use subscription callback like ROS1

especially why this is related to this feature?

@daisukes
Copy link
Contributor Author

daisukes commented Dec 9, 2022

@fujitatomoya
Sure, one example is ROS2 porting of the perception_pcl package, which utilizes these headers.
Thanks to the introduction of type adaptation with Humble, I think many resource-intensive nodelets (image_pipeline, pointcloud_to_laserscan, etc) will be ported to ROS2 component, and many of them inherit classes in the nodelet_topic_tools headers, especially nodelet_lazy.h.

As for the lazy subscription (which is used in nodelte_lazy.h) it needs the feature (ros2/rmw#330) to archive the functionality without polling the subscription match count.

rclcpp_component (equivalent to ROS1 nodelet) is in this repo, so, it would be great if these headers are in the common include.

Does this answer your questions?

@fujitatomoya
Copy link
Collaborator

thanks for the explanation, now i see what is requested here.

lazy subscription sounds to me like more general feature, not dedicated to ROS 1 nodelet or ROS 2 component, it sounds one of the subscription option for me. but agree that rclcpp and rclpy would be the best place to handle these feature for the application, i think.

just to be clear, this feature is out of scope ros2/rmw#330 activity for now. after ros2/rmw#330 is completed, contribution will be really welcome 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants