Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't enable set_logger_levels service for LifecycleNode #2273

Closed
bijoua29 opened this issue Aug 15, 2023 · 5 comments
Closed

Can't enable set_logger_levels service for LifecycleNode #2273

bijoua29 opened this issue Aug 15, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@bijoua29
Copy link

Bug report

Required Info:

  • Operating System:
    • Ubuntu 22.04
  • Installation type:
    • binaries
  • Version or commit hash:
    • latest rolling as of 2023-08-14
  • DDS implementation:
    • RTI Connext
  • Client library (if applicable):
    • rclcpp lifecycle_node

Steps to reproduce issue

The enable_logger_service for NodeOptions doesn't seem to be enabled for LifecycleNode

node_options.enable_logger_service(true);

Passing node_options to creation of LifecycleNode doesn't enable the logger service

Expected behavior

The set_logger_levels service should be available when doing a 'ros2 node info' on the lifecycle node

Actual behavior

The set_logger_levels service is not seen when doing a 'ros2 node info' on the lifecycle node

Additional information

I notice creating a non-lifecyle node i.e. a standard node, has the following code in the constructor

if (options.enable_logger_service()) {
    node_logging_->create_logger_services(node_services_);
}

However this doesn't exist in the constructor for the lifecycle node.

@fujitatomoya fujitatomoya self-assigned this Aug 16, 2023
@fujitatomoya fujitatomoya added the enhancement New feature or request label Aug 16, 2023
@fujitatomoya
Copy link
Collaborator

right, currently licecycle node does not have logging level configuration service. technically there are some feature gap between Node and LifecycleNode as known issue. we can of course add this feature based on rclcpp::node_interfaces::NodeLoggingInterface.

@bijoua29
Copy link
Author

Hmm. Ok. Is it as simple as adding

if (options.enable_logger_service()) {
    node_logging_->create_logger_services(node_services_);
}

in the LifecycleNode constructor or am I missing something?

@fujitatomoya
Copy link
Collaborator

implementation would be straight-forward to add the services, but test is also ideal. i think i can work on this.

@bijoua29
Copy link
Author

implementation would be straight-forward to add the services, but test is also ideal. i think i can work on this.

Thanks @fujitatomoya

@clalancette
Copy link
Contributor

This was solved by #2277, so I'm going to close this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants