Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport request - Unified NodeInterfaces in Humble #2309

Open
BrettRD opened this issue Sep 13, 2023 · 1 comment
Open

Backport request - Unified NodeInterfaces in Humble #2309

BrettRD opened this issue Sep 13, 2023 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@BrettRD
Copy link

BrettRD commented Sep 13, 2023

Feature request

I'd like to use a unified NodeInterfaces object from #2041 under ROS2 Humble.

Feature description

Fuse uses #2041 as an extremely tidy way of passing interfaces from the base node to its many pluginlib plugins.

I'm building a modular wrapper for GStreamer pipelines, intended to replace and unify gscam and audio_common, adding lots of features in the process.

A lot of complexity comes out of mapping the Properties of GStreamer Elements to Parameters on the Node, and I need ParameterEventHandler::add_parameter_callback to separate the rclcpp parameter validate and update stages to allow GStreamer elements to validate properties before accepting them.

ParameterEventHandler needs a NodeT macro type in its constructor, and satisfying that is making a mess of my ROS2 version portability.

Implementation considerations

#2041 appears to be the complete picture, I haven't found any discussion of why a back-port wouldn't be possible

@clalancette
Copy link
Contributor

It is certainly worth a try. Keep in mind that in a backport, we can't change API or ABI; as long as those rules are followed, I don't see a huge problem in doing it. That said, I don't think we'll have time to do it in the near future, so I'll mark this as "help wanted" for now.

@clalancette clalancette added enhancement New feature or request help wanted Extra attention is needed labels Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants