Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimersManager doesn't follow ROS time #2480

Open
alsora opened this issue Apr 3, 2024 · 4 comments
Open

TimersManager doesn't follow ROS time #2480

alsora opened this issue Apr 3, 2024 · 4 comments
Assignees

Comments

@alsora
Copy link
Collaborator

alsora commented Apr 3, 2024

Feature request

Feature description

Currently, the TimersManager class waits for timers to be ready using the following code

timers_cv_.wait_for(lock, time_to_sleep.value(), [this]() {return timers_updated_;});

This will always sleep using the system clock, even if the "time to sleep" was computed from a timer using the ROS clock

We should take into account the clock type when deciding how to sleep, and use an API that is aware of ROS clock

@fujitatomoya
Copy link
Collaborator

duplication of #2457. lets keep this alive as tracking issue, and i will close #2457.
CC: @alsora

@alsora
Copy link
Collaborator Author

alsora commented Apr 3, 2024

Ops, my bad.
I started looking into this problem and created a ticket without noticing we already had one.

@ros-discourse
Copy link

This issue has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/the-ros-2-c-executors/38296/4

@ros-discourse
Copy link

This issue has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/the-ros-2-c-executors/38296/13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants