overload functions for has_symbol and get_symbol with raw string literal #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
clalancette
approved these changes
Nov 2, 2020
There was a problem hiding this comment.
Yeah, I have to agree with this. @hidmic, what do you think?
hidmic
approved these changes
Nov 2, 2020
|
CI:
|
|
The failing test on Windows failed in the nightlies as well, so merging this. Thanks for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As rmw_implementation uses parameter
const char *to call these functions, it is best to provide overloaded functions inconst char*.Signed-off-by: Chen Lihui lihui.chen@sony.com