No windows.h in header files #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
|
clalancette
reviewed
Jan 11, 2021
There was a problem hiding this comment.
This is fantastic, and exactly what we need. Thanks for doing this!
I have two nits inline. Also, I'm wondering if we should just move the implementation of the constructor that takes a std::string into the C++ file as well. It is minor, but putting it there helps on compile times, and just makes it so all of the implementation is in one place.
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Moved all method and free function definitions to the source file in 82a0901. |
clalancette
approved these changes
Jan 12, 2021
|
CI (build everything, test rcpputils):
|
|
Same jobs also including ros2/rosbag2#600:
|
|
Windows once again, also testing ros2/rcl_logging#71:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
windows.hshould not be included in any header file because it bizarrely pollutes the global namespace with macros that can easily collide with other names.My favorites: min, max, ERROR, NO_ERROR, and even more.
IMO trying to make all our headers compatible with
windows.his a bit hopeless, so we should avoid includingwindows.hin header files and use custom workarounds in source files when appropriate (an#undefor#define NOMINMAXusually fix collisions).