require C++17 and deprecate the rcppmath namespace #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjwwood
commented
Aug 29, 2022
|
CI:
|
|
@ros-pull-request-builder test this please |
|
I've marked the agent that was exhibiting this issue offline to test. @ros-pull-request-builder retest this please. |
|
@ros-pull-request-builder retest this please. |
With this build the result is now UNSTABLE rather than failed and the infrastructure issues should be resolved. |
clalancette
requested changes
Aug 31, 2022
Signed-off-by: William Woodall <william@osrfoundation.org>
wjwwood
force-pushed
the
require_cpp17_and_deprecate_rcppmath_ns
branch
from
e4fa87c
to
7ec674f
Compare
Signed-off-by: William Woodall <william@osrfoundation.org>
|
New CI:
|
clalancette
approved these changes
Oct 12, 2022
|
The CI test failure on Windows is unrelated, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, now that we can use c++17 in rolling we can do away with the
clamp.hppheader because it's just implementingstd::clampwhich was added in c++17. Also as discussed in #85 (comment), removing thercppmathnamespace as it doesn't follow our conventions that packages should only put headers and symbols in their own namespace unless at all possible.