Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes for rcpputils::fs API #35

Merged
merged 5 commits into from
Feb 3, 2020
Merged

Bug fixes for rcpputils::fs API #35

merged 5 commits into from
Feb 3, 2020

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Jan 28, 2020 •
edited
Loading

Follow up after #30. Using absolute paths would make rcpputils::fs::create_directories fail otherwise. It also introduces a temp_directory_path() implementation solely for testing the aforementioned patch.

Edit: well, it turns out the parent_path() method was also broken.

CI up to rcpputils:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@hidmic
Ensure rcpputils::fs::create_directories works with absolute paths.
686e997 
Implement temp_directory_path() for testing purposes.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested a review from a team as a code owner January 28, 2020 12:48
wjwwood
wjwwood approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hidmic
Add missing header file.
935d1fc 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Use Win32 typedefs properly.
ab0d8c0 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Add error code to std::system_error.
6567488 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Fix rcpputils::fs::path::parent_path() method.
a96ae7b 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic changed the title Ensure rcpputils::fs::create_directories works with absolute paths. Bug fixes for rcpputils::fs API Jan 31, 2020
@hidmic
Copy link
Contributor Author

hidmic commented Feb 3, 2020

Alright, all green! Going in.

@hidmic hidmic merged commit 6f7484a into master Feb 3, 2020
@hidmic hidmic deleted the hidmic/another-fs-api-fix branch February 3, 2020 13:08
@jdlangs jdlangs mentioned this pull request Dec 22, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersonknapp emersonknapp emersonknapp approved these changes

@wjwwood wjwwood wjwwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hidmic @wjwwood @emersonknapp