Added unload_library method to shared_library #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
|
Have you tried this patch? I would assume if you invoke |
Signed-off-by: ahcorde <ahcorde@gmail.com>
|
Why introduce another field which needs to be kept in sync? E.g. in the current patch the state is wrong if the unloading fails. |
Signed-off-by: ahcorde <ahcorde@gmail.com>
dirk-thomas
reviewed
Apr 3, 2020
Signed-off-by: ahcorde <ahcorde@gmail.com>
|
|
Openning and clossing the issue to retest the github actions |
|
Openning and clossing the issue to retest the github actions |
Signed-off-by: ahcorde <ahcorde@gmail.com>
ahcorde
force-pushed
the
ahcorde/feature/shared_library_unload_method
branch
from
ac9350c
to
b676168
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the PR ros/class_loader#139 (review) I will include a unload method to the sharedLibrary abstraction
Signed-off-by: ahcorde ahcorde@gmail.com