Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed duplicated split function #54

Merged
merged 4 commits into from
Apr 14, 2020
Merged

Removed duplicated split function #54

merged 4 commits into from
Apr 14, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Apr 14, 2020

Removed a duplicated version of the split function. Using the one defined in split.hpp.

rcpputils/include/rcpputils/split.hpp

Lines 89 to 95 in 90adaa6

split(const std::string & input, char delim, bool skip_empty = false)
{
std::vector<std::string> result;
auto it = std::back_inserter(result);
split(input, delim, it, skip_empty);
return result;
}

Signed-off-by: ahcorde ahcorde@gmail.com

@ahcorde
Removed duplicated split function
90adaa6 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from a team as a code owner April 14, 2020 09:48
@ahcorde ahcorde self-assigned this Apr 14, 2020
@ahcorde ahcorde added the enhancement New feature or request label Apr 14, 2020
@ahcorde
Removed list from includes
1b24ab5 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 14, 2020

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 14, 2020

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 14, 2020 •
edited
Loading

All platforms warning

  • ament_cmake_export_interfaces

Windows warning:

  • spdlog_vendor warning

@ahcorde ahcorde merged commit 3275554 into master Apr 14, 2020
@ahcorde ahcorde deleted the ahcorde/fix/remove_duplicate_split branch April 14, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees

@ahcorde ahcorde

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahcorde @wjwwood