Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export targets in a addition to include directories / libraries #57

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

dirk-thomas
Copy link
Member

Allowing modern CMake usage.

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas requested a review from a team as a code owner April 17, 2020 21:37
@dirk-thomas dirk-thomas self-assigned this Apr 17, 2020
@dirk-thomas
Copy link
Member Author

CI builds using only FastRTPS:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Member

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, CI warning seem unrelated.

@dirk-thomas dirk-thomas merged commit 656e809 into master Apr 20, 2020
@dirk-thomas dirk-thomas deleted the dirk-thomas/export-targets branch April 20, 2020 16:33
@dirk-thomas
Copy link
Member Author

Related to ros2/ros2#904.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants