User setting for Qos depth is ignored while using Clinet/Service

[Barry-Xu-2018]

This problem was reported at ros2/rclcpp#1785.

After checking code, find

rmw_cyclonedds/rmw_cyclonedds_cpp/src/rmw_node.cpp

Line 4312 in 2aa2cf5

dds_qset_history(qos, DDS_HISTORY_KEEP_ALL, DDS_LENGTH_UNLIMITED);

This line of code causes user settings to be ignored.
Is there a reason for writing the code like this ? Or this is a bug ?

[eboasson]

It is a bug (see ros2/rclcpp#1785 (comment) for more info).

[Barry-Xu-2018]

It is a bug (see ros2/rclcpp#1785 (comment) for more info).

Thanks for your comments.

Based on the fact that the user should be responsible for his actions, if the user doesn't configure, we can keep the current default setting.
If the user wants to configure QoS, we accept user setting.