Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rmw_fastrtps_dynamic_cpp] Typesupport implementation leaks and it relies in conceptually broken cpp #428

Closed
ivanpauno opened this issue Sep 3, 2020 · 3 comments · Fixed by #429
Labels
bug Something isn't working

Comments

@ivanpauno
Copy link
Member

@ivanpauno ivanpauno added the bug Something isn't working label Sep 3, 2020
@ivanpauno
Copy link
Member Author

@iuhilnehc-ynos @richiprosima FYI

@MiguelCompany
Copy link
Collaborator

@ivanpauno @iuhilnehc-ynos I am currently addressing this on this branch

I still want to do more testing before opening a PR for it. Will do that on Monday

@MiguelCompany
Copy link
Collaborator

@ivanpauno PR #429 is ready for review. All reinterpret_cast<std::vector<unsigned char> *> have been removed, so I think it also fixes #219

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants