include module name which wasn't found in error message #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
added
enhancement
dirk-thomas
force-pushed
the
not_found_required_module
branch
2 times, most recently
from
92367e3 to
cf79d10
Compare
wjwwood
approved these changes
Jun 17, 2018
cmake/find_ros1_package.cmake
Outdated
| @@ -26,8 +26,16 @@ macro(find_ros1_package name) | |||
| set(_required "") | |||
There was a problem hiding this comment.
This is no longer required right?
There was a problem hiding this comment.
Good catch. Removed.
dirk-thomas
force-pushed
the
not_found_required_module
branch
from
cf79d10 to
ab0578f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg_check_modules()simply output the following not helpful error message when a requested module is not found:Therefore this patch handles printing the error message separately to include the module name.