Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to get response from ROS service runtime_error should be informative #166

Closed
tomasruizt opened this issue Feb 16, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@tomasruizt
Copy link

Feature request

runtime_error should be informative.

Feature description

Expected behavior

"what(): Failed to get response from ROS service: myservice/"

Actual behavior

"what(): Failed to get response from ROS service"

Implementation considerations

Change the code in:

throw std::runtime_error("Failed to get response from ROS service");

to

throw std::runtime_error("Failed to get response from ROS service: " + client.getService());

Optional

Maybe it should include the fact that the error was thrown from the ros1_bridge

@dirk-thomas
Copy link
Member

Please consider to create a pull request with your proposed patch.

@dirk-thomas dirk-thomas added the enhancement New feature or request label Feb 16, 2019
@tfoote tfoote added the in review Waiting for review (Kanban column) label Feb 16, 2019
@cottsay cottsay added in progress Actively being worked on (Kanban column) and removed in review Waiting for review (Kanban column) labels Feb 21, 2019
@dirk-thomas dirk-thomas added in progress Actively being worked on (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Mar 1, 2019
@dirk-thomas dirk-thomas removed the in progress Actively being worked on (Kanban column) label Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants