Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected publish calls with shared_ptr signature, leftovers #190

Merged
merged 3 commits into from
May 7, 2019

Conversation

ivanpauno
Copy link
Member

Leftovers of #188.

Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the in review Waiting for review (Kanban column) label May 7, 2019
@ivanpauno ivanpauno requested a review from wjwwood May 7, 2019 16:20
@ivanpauno ivanpauno self-assigned this May 7, 2019
@ivanpauno
Copy link
Member Author

  • Packaging Linux Build Status

Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno requested review from dirk-thomas and wjwwood May 7, 2019 18:20
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
@ivanpauno
Copy link
Member Author

ivanpauno commented May 7, 2019

Again CI:

  • Packaging Linux Build Status

@ivanpauno ivanpauno merged commit 626292c into master May 7, 2019
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/deprecate-shared-ptr-publish-leftovers branch May 7, 2019 20:28
@ivanpauno ivanpauno removed the in review Waiting for review (Kanban column) label May 7, 2019
dhananjaysathe pushed a commit to rapyuta-robotics/ros1_bridge that referenced this pull request Aug 22, 2019
* Corrected publish calls with shared_ptr signature, leftovers

Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>

* cpplint

Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
Signed-off-by: Dhananjay Sathe <dhananjay.sathe@rapyuta-robotics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants