use ament_target_dependencies where possible to order include dirs

[dirk-thomas]

Follow up of ament/ament_cmake#130.

[ivanpauno]

Am I in the right direction here ros2/rosidl_typesupport#46 and here ros2/geometry2#98?

If it is ok, I can take this issue

[ivanpauno]

@dirk-thomas This three PRs need a review:
ros/class_loader#121
ros2/rosidl_typesupport#46
ros2/rcl#400

I will run a CI job with this complete update after approval of the PRs.

[wjwwood]

@ivanpauno do you want to do CI for ros2/rviz#384 as well when you do the others? There's some test failures in the CI I ran, but it might be known issues.

[dirk-thomas]

This three PRs need a review:

I have already reviewed the second and third. @nuclearsandwich will review the first since he is the maintainer of that package/repo.

Please also set the label to match the status a ticket is supposed to have ("in review" rather than "in progress").

[jacobperron]

@ivanpauno It looks like all referenced PRs have been merged. Is there still more to do for this ticket or can it be closed?

[ivanpauno]

@ivanpauno It looks like all referenced PRs have been merged. Is there still more to do for this ticket or can it be closed?

I will check again before closing it.

[clalancette]

I'm actually going to close this out just to get it out of our review column. Feel free to reopen if you find more issues that need to be addressed as part of this.

[dirk-thomas]

@clalancette You do we ensure that this will be checked with the ticket closed?

[clalancette]

@clalancette You do we ensure that this will be checked with the ticket closed?

Nothing, but there is nothing to ensure it will be checked with it open either. Basically there is nothing actionable here, and having it just hanging out in the review column with everything merged means it is just wasting reviewer time looking at it for no reason. I could alternatively open it back up and switch to "in progress", but it definitely shouldn't be "in review".

[dirk-thomas]

Currently there is no ticket to follow up on "I will check again before closing it.". Therefore I will reopen it.

[ivanpauno]

I opened two PRs, addressing the leftovers I've found. I will close this issue after merging them.