Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2component] List occasionally fails to retrieve components #221

Closed
jubeira opened this issue Apr 16, 2019 · 3 comments
Closed

[ros2component] List occasionally fails to retrieve components #221

jubeira opened this issue Apr 16, 2019 · 3 comments
Assignees
Labels
more-information-needed Further information is required

Comments

@jubeira
Copy link
Contributor

jubeira commented Apr 16, 2019

Bug report

Required Info:

  • Operating System:
    • Ubuntu 18.04
  • Installation type:
    • Source
  • Version or commit hash:
    • Hash 930dea5c8de47d47ac0b3814ee1c08bac8a70c22 (Fix component arguments to be inline with service. (#220)) + rclcpp_components from binaries version 0.7.0.
  • DDS implementation:
    • RTI Connext
  • Client library (if applicable):
    • N/A

Steps to reproduce issue

  1. From a terminal, run rclcpp_components:
ros2 run rclcpp_components component_container
  1. From a second terminal, add some components (tested with 2 talkers and 2 listeners):
ros2 component load /ComponentManager composition composition::Talker
ros2 component load /ComponentManager composition composition::Listener
ros2 component load /ComponentManager composition composition::Talker
ros2 component load /ComponentManager composition composition::Listener

The interaction between talkers and listeners should be displayed in the first terminal, e.g:

[INFO] [talker]: Publishing: 'Hello World: 114'
[INFO] [listener]: I heard: [Hello World: 114]
[INFO] [listener]: I heard: [Hello World: 114]
[INFO] [talker]: Publishing: 'Hello World: 29'
[INFO] [listener]: I heard: [Hello World: 29]
[INFO] [listener]: I heard: [Hello World: 29]
  1. List the components:
ros2 component list

Expected behavior

Components should be listed like this:

/ComponentManager
    1  /talker
    2  /listener
    3  /talker
    4  /listener

Actual behavior

~20% of the times, no component is listed.

Additional information

This doesn't seem to happen in fastrtps nor opensplice.

@dirk-thomas
Copy link
Member

Does the problem disappear when passing --spin-time N with a long enough period to ensure the node started by ros2 component list has enough time to complete discovery?

@dirk-thomas dirk-thomas added more-information-needed Further information is required and removed ready Work is about to start (Kanban column) bug Something isn't working labels May 22, 2019
@jubeira
Copy link
Contributor Author

jubeira commented May 22, 2019

I need to rebuild by workspace with the current packages to retest properly; right now it is heppening to me even with --spin-time 10, but I want to make sure it's not a local issue. I'll try again and post the results here.

@jubeira
Copy link
Contributor Author

jubeira commented May 23, 2019

@dirk-thomas I can't reproduce this issue anymore using an up-to-date workspace from source.
For completion I tried listing the components 20 times in a row with FastRTPS, OpenSplice and Connext and it didn't fail even a single time. --spin-time N option wasn't required.

I think this issue is safe to close.

@jubeira jubeira closed this as completed May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more-information-needed Further information is required
Projects
None yet
Development

No branches or pull requests

4 participants