Warning when using rosbag2 mcap on humble: No storage plugin found with id 'mcap'

[ajayvohra2005]

Description

When I open a rosbag2 recorded with mcap in a Python client, I get the warning below:
[rosbag2_storage]: No storage plugin found with id 'mcap'

Other than the warning, it appears to work fine and I see no other errors.

Expected Behavior

Do not expect to see no [rosbag2_storage]: No storage plugin found with id 'mcap' warning.

Actual Behavior

[WARN] [1670089642.967771980] [rosbag2_storage]: No storage plugin found with id 'mcap'

To Reproduce

** Steps to reproduce the behavior, e.g.

>>> import rosbag2_py
>>> bag_path= # set to your rosbag2 directory
>>> reader = rosbag2_py.SequentialReader()
>>> storage_options=rosbag2_py.StorageOptions(uri=bag_path, storage_id='mcap', storage_preset_profile="zstd_fast")
>>> converter_options = rosbag2_py.ConverterOptions(input_serialization_format='cdr',output_serialization_format='cdr')
>>> reader.open(storage_options, converter_options)
[WARN] [1670089642.967771980] [rosbag2_storage]: No storage plugin found with id 'mcap'.
>>>

System (please complete the following information)

• OS: Ubuntu Jammy
• ROS 2 Distro: Humble
• Version: [release, branch, or commit hash]

Additional context

** Add any other context about the problem here **

[emersonknapp]

I'm not 100% certain - everything is working OK, it just prints this unexpected warning? Or, it is not working properly?

[MichaelOrlov]

• It looks like duplicate of the Unable to record in MCAP since last Humble sync #1191

[wep21]

rosbag2/rosbag2_storage/src/rosbag2_storage/impl/storage_factory_impl.hpp

Lines 183 to 201 in 05d2e43

	// try all registered ReadOnly plugins first
	auto instance = get_interface_instance(
	read_only_class_loader_, storage_options);
	// try ReadWrite plugins if no ReadOnly plugin was found
	if (instance == nullptr) {
	instance = get_interface_instance<ReadWriteInterface, storage_interfaces::IOFlag::READ_ONLY>(
	read_write_class_loader_, storage_options);
	}
	if (instance == nullptr) {
	if (storage_options.storage_id.empty()) {
	ROSBAG2_STORAGE_LOG_ERROR_STREAM(
	"No storage id specified, and no plugin found that could open URI");
	} else {
	ROSBAG2_STORAGE_LOG_ERROR_STREAM(
	"Could not load/open plugin with storage id '" << storage_options.storage_id << "'");
	}
	}

I guess when opening a read only interface, read-only plugins are explored first, so no storage plugin warnings are always coming up because sqlite3 or mcap is a read write plugin.

[MichaelOrlov]

Ahh, - if you are just worry about those warning and everything else works as expected. Then yes we have fixed those warning on rolling in the scope of the

• Don't reopen file for every seek if we don't have to. Search directionally for the correct file #1117
• I have created Draft: [Humble] Don't reopen file for every seek if we don't have to. Search directionally for the correct file (backport #1117) #1201 - Although not sure if we will be able to merge it to Humble since it's adding new virtual method virtual void load_prev_file(); and it could break ABI compatibility.
• Anyway as alternative we can just remove those logging warning in

  rosbag2/rosbag2_storage/src/rosbag2_storage/impl/storage_factory_impl.hpp

  Lines 119 to 120 in e9c1015

  	ROSBAG2_STORAGE_LOG_WARN_STREAM(
  	"No storage plugin found with id '" << storage_options.storage_id << "'.");

[emersonknapp]

Anyway as alternative we can just remove those logging warning in

I thing we should just do this - the messaging was always misleading.

[emersonknapp]

Fixed in #1219