-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve workarounds in rosbag2_tests for Windows #271
Comments
I have created a Pytest that can successfully execute a I opened an issue (colcon/colcon-core#303) to discuss why this is the case and propose a path forward. An potential approach in the future would be to use |
As per our discussion yesterday, it might make sense to rewrite the e2e tests in Python and use |
I think one helpful addition would be to introduce a |
|
test_rosbag2_record_end_to_end
defines a workaround for Windows in multiple places due to Windows not supporting a mechanism to programmatically send a SIGINT.These tests should either be rewritten to not require the workaround or a helper function should be written so less platform-specific code is required.
The text was updated successfully, but these errors were encountered: