Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to IDL #346

Closed
8 tasks done
dirk-thomas opened this issue Jan 25, 2019 · 7 comments
Closed
8 tasks done

Migrate to IDL #346

dirk-thomas opened this issue Jan 25, 2019 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@dirk-thomas
Copy link
Member

dirk-thomas commented Jan 25, 2019

This is a meta ticket based on #298 which has since been split up into multiple PRs.

The goal is to use .idl files (using a subset of OMG IDL 4.2) to specify messages, services, actions and potentially more in the future. See https://github.com/ros2/ros2/blob/idl/README.rst#goals for a collection of bullets and references.

List of tasks and features (to be collect here from various places):

  • fix problems extracting verbatim annotations from AST into object representation
  • split action definitions into user provided types (goal, result, feedback) and wrapping types (send_goal service, get_result service, feedback_message)
  • investigate extreme runtime for parsing some .idl files
  • change uuid type to external message (see update tests to use separated action types rcl#340 (comment))
  • get all tests to pass again...
  • ensure keys are passed through to the vendor specific tools
  • resolve action API problems
  • readd target dependency on absolute path of .idl files

The latest set of patches using the branch name idl-stage-7:

@dirk-thomas dirk-thomas added the enhancement New feature or request label Jan 25, 2019
@dirk-thomas dirk-thomas self-assigned this Jan 25, 2019
@cottsay cottsay added the ready Work is about to start (Kanban column) label Jan 31, 2019
@dirk-thomas dirk-thomas added in progress Actively being worked on (Kanban column) and removed ready Work is about to start (Kanban column) labels Feb 12, 2019
@dirk-thomas
Copy link
Member Author

dirk-thomas commented Feb 19, 2019

  • Linux FastRTPS only Build Status
  • Linux Build Status
  • Linux aarch64 Build Status
  • macOS Build Status
  • Windows Build Status (same test failing in the nightly jobs)

@dirk-thomas
Copy link
Member Author

dirk-thomas commented Feb 27, 2019

  • Linux Build Status
  • Linux-aarch64 Build Status (known flaky test test_params_yaml)
  • macOS Build Status
  • Windows Build Status (known flaky test test_params_yaml)

@dirk-thomas
Copy link
Member Author

Including OpenSplice:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@dirk-thomas
Copy link
Member Author

dirk-thomas commented Mar 4, 2019

Hopefully the last round before merging - again including OpenSplice:

  • Linux Build Status (known: test_params_yaml)
  • Linux-aarch64 Build Status (known: test_params_yaml, test_pendulum with OpenSplice)
  • macOS Build Status (various tests around parameters with OpenSplice - not failing with master...)
  • Windows Build Status (known: test_params_yaml, test_graph with OpenSplice)

@dirk-thomas
Copy link
Member Author

dirk-thomas commented Mar 11, 2019

All RMW:

  • Linux Build Status (test_params_yaml)
  • Linux-aarch64 Build Status (test_params_yaml, test_pendulum with OpenSplice)
  • macOS Build Status (various parameter tests with OpenSplice)
  • Windows Build Status (test_params_yaml)

Only FastRTPS:

  • Linux Build Status
  • Linux-aarch64 Build Status (test_params_yaml)
  • macOS Build Status
  • Windows Build Status (test_params_yaml)

Only Connext:

Only OpenSplice:

  • Linux Build Status
  • Linux-aarch64 Build Status (test_pendulum with OpenSplice)
  • macOS Build Status (same 6 test failures as on master, rclcpp_action/test_client)
  • Windows Build Status (test_timer, test_two_timers)

@dirk-thomas
Copy link
Member Author

All the above referenced PRs have been merged. Before closing this ticket I will create a few tickets with follow up work...

@dirk-thomas
Copy link
Member Author

The existing design documents have been updated and published in: ros2/design#215

A note has been added to the Dashing page about the need to update message generators: ros2/ros2_documentation#139

And with the current status being captures in https://github.com/ros2/ros2/blob/idl/README.rst I am closing this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants