Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request backporting string literals fix to Dashing #418

Closed
TSC21 opened this issue Oct 14, 2019 · 2 comments
Closed

request backporting string literals fix to Dashing #418

TSC21 opened this issue Oct 14, 2019 · 2 comments

Comments

@TSC21
Copy link

TSC21 commented Oct 14, 2019

@dirk-thomas @mjcarroll it was reported in #406, and fixed in #409 and #410, the bug with string literals and multiline comments in IDL files. The bug was reported on ROS2 Dashing, which is an LTS version that I supposed it should be used to stabilise package APIs using Dashing (which is something I am looking to do).

I see that rosidl package released under 0.8.0 tag are only available under ROS2 Eloquent, and only version 0.7.6 is available to Dashing, which doesn't fix the bug on regarding the multiline comments (string literals).

Is it possible to make the 0.8.0 also available under Dashing, or at least back port the above fixes, in order to address the same bug? Doesn't seem reasonable to bump into a new ROS version in order to solve a bug.

Thanks in advance!

TSC21 referenced this issue Oct 14, 2019
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@TSC21 TSC21 changed the title rosidl 0.8.0 release to Dashing rosidl 0.8.0 release to Dashing (or backport string literals fix) Oct 14, 2019
@dirk-thomas dirk-thomas changed the title rosidl 0.8.0 release to Dashing (or backport string literals fix) request backporting string literals fix to Dashing Oct 15, 2019
@dirk-thomas
Copy link
Member

Thanks for the report.

#409 was already backported to Dashing in #417.

#410 (and #411) are being backported to Dashing by #403

@TSC21
Copy link
Author

TSC21 commented Oct 15, 2019

Thank you @dirk-thomas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants