Add test_xmllint to rosidl_pycommon. #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is one of the tests that it is currently missing, and will validate if the package.xml is bad for some reason. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette
requested review from
adityapande-1995,
methylDragon,
quarkytale and
sloretz
as code owners
sloretz
requested changes
Oct 31, 2024
There was a problem hiding this comment.
I think the package.xml needs a <test_depend> on ament_xmllint
rosidl/rosidl_pycommon/package.xml
Lines 20 to 24 in 104f3e0
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Good call. Fixed in 8355699 |
sloretz
approved these changes
Oct 31, 2024
|
Pulls: #833
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is one of the tests that it is currently missing, and will validate if the package.xml is bad for some reason.
This is part of getting to ros2/ros2cli#944 , in the sense that it fixes the core to actually do this. @sloretz FYI