Skip to content

Commit

Permalink
Don't validate overall actions (Backort of # 44) (#45)
Browse files Browse the repository at this point in the history
Works around a limitation where the generation for the overall action doesn't know about messages in the same package.

Signed-off-by: Shane Loretz<sloretz@openrobotics.org>
  • Loading branch information
sloretz authored and nuclearsandwich committed Mar 10, 2019
1 parent bda9bb4 commit fc4929c
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion rosidl_typesupport_cpp/rosidl_typesupport_cpp/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,9 @@ def generate_cpp(generator_arguments_file, type_supports):

elif extension == '.action':
spec = parse_action_file(pkg_name, ros_interface_file)
validate_field_types(spec, known_msg_types)
# TODO(sloretz) validate field types when overall action is generated with msg and srv
# https://github.com/ros2/rosidl/issues/348#issuecomment-462874513
# validate_field_types(spec, known_msg_types)
for template_file, generated_filename in mapping_actions.items():
generated_file = os.path.join(
args['output_dir'], subfolder, generated_filename %
Expand Down

0 comments on commit fc4929c

Please sign in to comment.