[Crystal patch 3 backport] Don't validate overall actions (#44) #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works around a limitation where the generation for the overall action doesn't know about messages in the same package. Signed-off-by: Shane Loretz<sloretz@openrobotics.org>
This was referenced Mar 7, 2019
Closed
This comment has been minimized.
This comment has been minimized.
10 tasks
nuclearsandwich
approved these changes
Mar 8, 2019
|
CI with latest Crystal development branches and proposed backports:
|
|
The test failures are caused by ros2/rmw_connext#348 and ros2/launch#169 not being present in Crystal and which aren't related to this repository's backport. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #44. Note: this branch is just a fast-forward to 183782e since there are no other changes since crystal release.
As such it can be merged instead of squash/merged.Edit: looks like the right button is rebase and merge since merge forces a merge commitros2/ros2#656