Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate C++ typesupport for actions #10

Closed
sloretz opened this issue Oct 18, 2018 · 1 comment
Closed

Generate C++ typesupport for actions #10

sloretz opened this issue Oct 18, 2018 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@sloretz
Copy link
Contributor

sloretz commented Oct 18, 2018

Feature request

Feature description

rosidl_typesupport_fastrtps_c needs to be aware of actions and generate typesupport for them.

Implementation considerations

CMake Code

The CMake code is expected to change with the IDL work, but at a minimum what's currently there needs to be able to recognize .action files.

Services in .action folder

The service templates would need to change to allow service definitions to live in the .actions folder

#include "@(spec.pkg_name)/srv/@(get_header_filename_from_msg_name(spec.srv_name + '_Request'))__rosidl_typesupport_fastrtps_c.h"
#include "@(spec.pkg_name)/srv/@(get_header_filename_from_msg_name(spec.srv_name + '_Response'))__rosidl_typesupport_fastrtps_c.h"

Parsing code

The parsing code needs a switch if the file is an action file, and if so call the appropriate parser for actions.

@sloretz sloretz added the enhancement New feature or request label Oct 18, 2018
@sloretz sloretz added this to the crystal milestone Oct 18, 2018
@sloretz sloretz mentioned this issue Oct 18, 2018
24 tasks
@sloretz
Copy link
Contributor Author

sloretz commented Oct 18, 2018

Closing in favor of just making rmw specific typesupports able to generate services in another folder

#9 (comment)

@sloretz sloretz closed this as completed Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant