Fixes policy CMP0135 warning for CMake >= 3.24 #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
clalancette
approved these changes
Sep 9, 2022
Blast545
requested changes
Sep 12, 2022
There was a problem hiding this comment.
LGTM, @Crola1702 please take a look to the linter errors before merging. Those are related to your changes.
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
clalancette
requested changes
Sep 12, 2022
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
|
New CI_launcher builds with fixes and new behaviour:
|
clalancette
approved these changes
Sep 12, 2022
Blast545
approved these changes
Sep 12, 2022
delete-merged-branch
bot
deleted the
Crola1702/fix-cmp0135-policy-warning
branch
|
@Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 3, 2023
* Fixes policy CMP0135 warning for CMake >= 3.24 Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com> (cherry picked from commit 1ea07e8)
clalancette
pushed a commit
that referenced
this pull request
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Crola1702 cristobal.arroyo@ekumenlabs.com
Reference build: https://ci.ros2.org/view/nightly/job/nightly_win_deb/2473/
This warning started appearing on new windows machines. It’s caused by a new CMake version (3.24) that expects this policy to be set.
This PR sets CMP0135 policy in
CMakeLists.txtCI launch: