Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing verb tests #193

Open
2 tasks
kyrofa opened this issue Apr 8, 2020 · 2 comments
Open
2 tasks

Missing verb tests #193

kyrofa opened this issue Apr 8, 2020 · 2 comments
Labels
good first issue Good for newcomers

Comments

@kyrofa
Copy link
Member

kyrofa commented Apr 8, 2020 •
edited
Loading

We have absolutely no tests for the following verbs

  • create_permission
  • generate_artifacts
@kyrofa kyrofa mentioned this issue Apr 8, 2020
Merged
@kyrofa kyrofa added the good first issue Good for newcomers label Apr 8, 2020
@mikaelarguedas
Copy link
Member

For completeness:
generate_policy has a lot of tests. The entire verb has been commented out temporarily pending underlying work (tracked at #182)
distribute_key has no code associated to it and will likely be removed for Foxy

However create_permission and generate_artifacts would definitely benefit from added test coverage 👍

@kyrofa
Copy link
Member Author

kyrofa commented Apr 8, 2020

Ah! Right you are, thanks for correcting me. I've updated the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kyrofa @mikaelarguedas