Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

agency filtering is broken #23

Open
rosnfeld opened this issue Jan 31, 2014 · 3 comments
Open

agency filtering is broken #23

rosnfeld opened this issue Jan 31, 2014 · 3 comments
Assignees
@rosnfeld
Labels
bug

Comments

@rosnfeld
Copy link
Owner

Many agency names are associated with a single agency code.

Are they namespaced by donor? Or just broken in the source data?
@ghost ghost assigned rosnfeld Jan 31, 2014
@rosnfeld
Copy link
Owner Author

Yes, namespaced by donor. It should be noted that the reverse mapping is also broken - a given name is fairly generic and can map to multiple codes. So presenting this in the UI will require more work, agencies will need to be presented as "[donor]/[agency]".

@rosnfeld
Copy link
Owner Author

This should probably "wait" on reworking all the internals to only use filters dynamically, not saving them, otherwise it's wasted work.

@rosnfeld rosnfeld modified the milestones: 2014-01-31 Milestone, 2014-02-15 Milestone Feb 7, 2014
@rosnfeld
Copy link
Owner Author

I should note that this "half works" - if you have selected the donor associated with the desired agency, then selecting the agency will work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rosnfeld rosnfeld

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rosnfeld