Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust full - last line #152

Open
twoSGmbH opened this issue Jun 21, 2021 · 6 comments
Open

Adjust full - last line #152

twoSGmbH opened this issue Jun 21, 2021 · 6 comments

Comments

@twoSGmbH
Copy link

twoSGmbH commented Jun 21, 2021

Hello,

with the commit 00db904 you deleted the calculation of the text option "full" for the last line. We think, its a better moving with the deleted calculation. Only adjust full, when 90 percent of the width is used. This is, why we say its a bug.
Can you say, why do you deleted this?

Thank you for the reply.

Best regards

@ole1986
Copy link
Collaborator

ole1986 commented Jun 28, 2021

To be honest I could not remember.
I was expecting to behave the same as "common text writers" but with my last finding that could be wrong.

So, I think that should than be configurable at least but also get a default value.
I will try to investigate some time for this topic

@ole1986
Copy link
Collaborator

ole1986 commented Jun 28, 2021

Oh, I remember its justified similar to what CSS styles text-align: justify does.

@twoSGmbH
Copy link
Author

Hi,

I think the CSS style text-align: justify is the best option. Its only stretch the line if the current line not the last. This is better than the 80 % calculation. It's the same process as word it have.

Can you integrate this solution? (Without the 80 % calculation)

@ole1986
Copy link
Collaborator

ole1986 commented Aug 23, 2021

to be honest I do not know when I have the chance to focus on this project.
But feel free to add a PR. I can quickly review and we are good to go

@kevinsdb
Copy link

@ole1986
Hope you had a good Christmas!
Have you had time to look into this issue?
Best,
Kevin

@ole1986
Copy link
Collaborator

ole1986 commented Dec 31, 2021

@kevinsdb
unfortunately I did not had the chance yet to get into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants