Fix/formatting #57
Merged
Fix/formatting #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningvera
requested changes
Jan 11, 2020
Codecov Report
@@ Coverage Diff @@
## master #57 +/- ##
==========================================
- Coverage 94.37% 92.46% -1.91%
==========================================
Files 3 3
Lines 231 239 +8
==========================================
+ Hits 218 221 +3
- Misses 9 11 +2
- Partials 4 7 +3
Continue to review full report at Codecov.
|
sum2000
force-pushed
the
fix/formatting
branch
2 times, most recently
from
45661e8 to
16b9709
Compare
sum2000
force-pushed
the
fix/formatting
branch
from
16b9709 to
2933999
Compare
morningvera
approved these changes
Jan 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to pass the format object to the new methods instead of interface since that is easier for the implementer. Let me know if you think the interface makes more sense and why.