Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return correct stack for local/global vars and add stack tests #74

Merged
merged 1 commit into from
Feb 13, 2020
Merged

fix: return correct stack for local/global vars and add stack tests #74

merged 1 commit into from
Feb 13, 2020
+218 −87

Conversation

morningvera
Copy link
Member

closes #54

@morningvera morningvera added the bug Something isn't working label Feb 8, 2020
@morningvera morningvera added this to the v0.3.0 milestone Feb 8, 2020
@morningvera morningvera requested a review from sum2000 February 8, 2020 21:03
@codecov-io
Copy link

codecov-io commented Feb 8, 2020 •
edited
Loading

Codecov Report

Merging #74 into master will increase coverage by 2.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   93.54%   95.63%   +2.08%     
==========================================
  Files           3        3              
  Lines         248      252       +4     
==========================================
+ Hits          232      241       +9     
+ Misses          9        5       -4     
+ Partials        7        6       -1
Impacted Files Coverage Δ
eris.go 100% <100%> (ø) ⬆️
stack.go 95.16% <100%> (+8.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe18b71...30ff8e9. Read the comment docs.

@morningvera morningvera force-pushed the fix/stack-tests branch 3 times, most recently from ba575b2 to 6dde6db Compare February 11, 2020 16:26
morningvera
morningvera commented Feb 13, 2020
View reviewed changes
eris.go Show resolved Hide resolved
morningvera
morningvera commented Feb 13, 2020
View reviewed changes
eris.go Show resolved Hide resolved
morningvera
morningvera commented Feb 13, 2020
View reviewed changes
stack.go Show resolved Hide resolved
sum2000
sum2000 previously approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@sum2000 sum2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some minor comments but approving

eris.go Show resolved Hide resolved
eris_test.go Show resolved Hide resolved
stack.go Show resolved Hide resolved
stack_test.go Show resolved Hide resolved
@morningvera morningvera requested a review from sum2000 February 13, 2020 16:26
@morningvera morningvera merged commit 17b0393 into master Feb 13, 2020
@morningvera morningvera deleted the fix/stack-tests branch February 21, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sum2000 sum2000 sum2000 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

Look into using CallersFrames instead of Callers/FuncForPC
3 participants
@morningvera @codecov-io @sum2000