-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Governor for Nitro #91
Comments
A fallback flight mode dependent throttle curve incase the RPM sensor gives out invalid data / RPM is outside expected range / fails is also a standard feature of an IC gov. See ardupilots implementation of govener on: See GOV MODE 3 for throttle curve mode: |
I want to add that being able to enable / disable the Gov in different flight modes / banks is super important for Nitro as well. The gov can mask effects / tendencies of badly tuned engines. For example, I always do engine tuning (carb needle tuning) with gov off, and only enable the gov after the engine has been tuned. There is currently no way in RF to have gov on/off dynamically. |
The logic Futaba have used for decades for their IC gov is very sound and would be good to look at for ideas when implementing any nitro or IC mode for RF gov. A few points to note from their system. There is a specific mode for IC engines in their gov that has certain IC specific logic and parameters.
I think these are the main IC specific concepts/points that are good to keep in mind when designing an IC gov mode for RF. |
I propose incorporating VBAR's simplified method, which i believe could leverage existing Rotorflight code. This method uses throttle input to switch between Throttle Passthrough and Governor mode. Throttle ≤ 50%: Throttle is passed through, allowing engine start and idle adjustment via a pot. This approach eliminates the need for a special idle profile and supports electric setups by keeping the throttle curve at 100%. I haven't yet tested Rotorflight on a gas engine, so the current governor's effectiveness with gas engine lag is still uncertain for me. |
The text was updated successfully, but these errors were encountered: