Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipenv support #7

Closed
jairojair opened this issue Sep 16, 2017 · 10 comments
Closed

Pipenv support #7

jairojair opened this issue Sep 16, 2017 · 10 comments

Comments

@jairojair
Copy link

Hi @rougeth

What 'u think add support to pipenv?

https://github.com/kennethreitz/pipenv

@rougeth
Copy link
Owner

rougeth commented Sep 16, 2017

@jairojair I never used pipenv and I know just a bit about it. But actually I know there is a lot of people talking about it. Do you know the benefits?

@rougeth
Copy link
Owner

rougeth commented Sep 23, 2017

@jairojair I'm probably going to support it, I'm just focusing on tests and docs right now, so this will take a bit to be done.

@gabrielecker
Copy link

May I work on this?

@rougeth
Copy link
Owner

rougeth commented Sep 29, 2017

@gabrielecker sure!

@gabrielecker
Copy link

So just to be clear, by supporting pipenv you mean just adding its dependencies files?

@rougeth
Copy link
Owner

rougeth commented Oct 2, 2017

@gabrielecker actually it's probably just the Pipfile integrated to setup.py. @jairojair what did you have in mind?

@rougeth
Copy link
Owner

rougeth commented Oct 2, 2017

@gabrielecker I'm sorry, like I said, I know just a bit about pipenv, pipfile, etc and its benefits. Maybe we should discuss it more, what do you have in mind too?

@gabrielecker
Copy link

gabrielecker commented Oct 2, 2017

I've been searching about setup.py and Pipfile integration and it looks like an anti-pattern.
There are a few statements from the own pipenv creator above:

tl;dr: your setup.py is broken. setup.py should not import pipenv. that's horrible practice.

e.g. a pipfile in that repo is for reproducing a dev environment, the setup.py is for installing the package itself.

https://github.com/kennethreitz/pipenv/issues/571

@gabrielecker
Copy link

So pipenv is not likely to be part of final installation. Actually it's an alternative to the classic requirements.txt which automatically integrates with virtual environments and splits the production and development dependencies by its own.

@rougeth
Copy link
Owner

rougeth commented Oct 8, 2017

@gabrielecker I'm sorry for the delay (just saw your lighting talk on #pybr13 hahaha congrats!). Well, let's close this issue, right?

@rougeth rougeth closed this as completed Oct 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants