Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Org mode table content is difficult to read #16

Open
mtbakerguy opened this issue Oct 9, 2020 · 9 comments
Open

Org mode table content is difficult to read #16

mtbakerguy opened this issue Oct 9, 2020 · 9 comments

Comments

@mtbakerguy
Copy link
Contributor

Thanks for the elegant theme as it's amazing. Between the font, color scheme, and minimal startup, it's brilliant. I have noticed one readability problem--the content of org mode tables is difficult to see.

@mtbakerguy
Copy link
Contributor Author

Forgot to mention that this is in the dark theme.

@mtbakerguy
Copy link
Contributor Author

I went ahead and changed the following to make the text easier to read:

(set-face-attribute 'face-faded nil :foreground "#7777a7"
:weight 'light)

Change the color from #777767 to #7777a7.

@rougier
Copy link
Owner

rougier commented Oct 12, 2020

Thanks! Could you post a screen shot before after ?

@mtbakerguy
Copy link
Contributor Author

image
before

image
after

@terlar
Copy link

terlar commented Oct 12, 2020

Perhaps the issue is that table body is using the faded face.

@rougier
Copy link
Owner

rougier commented Oct 12, 2020

I guess it would be better to use the default face for the table column marker. Do you know the name of the face? (is there a dedicated one?)

@terlar
Copy link

terlar commented Oct 12, 2020

I don't think there is a face for the table column marker, there is the face is org-table which I think is used by both markers and table content.

BTW, slightly unrelated, but might find interesting, you can "prettify" tables via the https://github.com/casouri/valign
That already has logic for the structural elements, perhaps an issue could be opened to add a face as well, then they could also be styled differently.

@rougier
Copy link
Owner

rougier commented Oct 12, 2020

Thanks for the link, great package. I need to study it further but it might be really useful for alignment in the header line.
I've checked the org-table and you're right, there's only one face so maybe it would be better to use the default face instead of faded. I would be nicer to have a separate face for border but this would require hacking org-mode I guess.

@rougier
Copy link
Owner

rougier commented Oct 12, 2020

Can you make a PR with default face?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants