Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New column type for Array - To be displayed as with subtable view #959

Closed
shamsmosowi opened this issue Nov 19, 2022 Discussed in #956 · 12 comments
Closed

New column type for Array - To be displayed as with subtable view #959

shamsmosowi opened this issue Nov 19, 2022 Discussed in #956 · 12 comments
Labels
enhancement New feature or request job-task

Comments

@shamsmosowi
Copy link
Member

shamsmosowi commented Nov 19, 2022

Add a new column type: ArrayTable

This is a repeated ask from users of Rowy to support array fields of Firestore, for example here

Task:

  • Create a new column type called Array: Documentation for adding a new column is available here.
  • This Array field on the Rowy Table UI should open similarly to how subtable column type shows up.
  • However on the Firestore side, the data should be stored as an array as shown below and not a subcollection (subtable field is stored as a subcollection).

Screen Shot 2022-12-30 at 1 02 27 am

image

@shamsmosowi shamsmosowi added enhancement New feature or request good first issue Good for newcomers labels Nov 19, 2022
@S-P-Ks
Copy link

S-P-Ks commented Nov 21, 2022

I can take this task.

@harinij
Copy link
Member

harinij commented Nov 21, 2022

Hi @S-P-Ks I have assigned the task to you. Please join us on discord if you like any additional information or want to discuss technical details under the #contribution channel.

@ashutosh887
Copy link

HI @harinij
Is this Task resolved?

@shamsmosowi shamsmosowi assigned ashutosh887 and unassigned S-P-Ks Dec 22, 2022
@ashutosh887
Copy link

Thanks for assigning me!
Can you tell me how to get started with Project @shamsmosowi !

@harinij
Copy link
Member

harinij commented Dec 29, 2022

@ashutosh887 since you are already assigned #519, I am going to unassign this task from you and reassign it to someone else as per our contribution guidelines

@harinij harinij changed the title Displaying an array of objects in a document using a subtable view New column type for Arrays - To be displayed as with subtable view Dec 29, 2022
@harinij harinij changed the title New column type for Arrays - To be displayed as with subtable view New column type for Array - To be displayed as with subtable view Dec 29, 2022
@jyash97
Copy link
Contributor

jyash97 commented Dec 29, 2022

Hey 👋

I am working into this issue, and have setup the project locally and looked into how the to add the column.

But not sure how do we want to render the UI, if you can give more context on the UI of editing and displaying the cell value. Do we want the array to be typed ? Like shown in the screenshot ?

@shamsmosowi
Copy link
Member Author

hi @jyash97,
To give you more context, we already have column type called subtable, which renders a table for specified subcollection. The idea here is to have the same experience but for an array of objects in same document rather than in a subcollection.
highly recommend trying out the subtable column type first, it should give you a good idea

@jyash97
Copy link
Contributor

jyash97 commented Dec 29, 2022

So we want a bottom drawer ? With a button to add array item and the item can be string, number or even a JSON ?

@shamsmosowi
Copy link
Member Author

shamsmosowi commented Dec 29, 2022

Yes, it'll be a bottom drawer like the subtable, however you add JSON objects to the array instead of documents in a subtable

@jyash97
Copy link
Contributor

jyash97 commented Dec 29, 2022

@shamsmosowi

I was looking at JSON field type as well, it also provides a option to add array, couldn't this be done through that ?
image

@shamsmosowi
Copy link
Member Author

Yes, currently that's the only way of modifying arrays on rowy. However, it's not as intuitive as the table experience

@harinij harinij added job-task and removed good first issue Good for newcomers labels Jan 9, 2023
@harinij
Copy link
Member

harinij commented May 2, 2023

New column types Array and Array Subtable has been added to Rowy.

@harinij harinij closed this as completed May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request job-task
Projects
None yet
Development

No branches or pull requests

5 participants