Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to save image #259

Closed
johanbook opened this issue Oct 14, 2020 · 10 comments
Closed

Unable to save image #259

johanbook opened this issue Oct 14, 2020 · 10 comments

Comments

@johanbook
Copy link

johanbook commented Oct 14, 2020

This issue is a:

  • Bug report

Expected behavior

To be able to right click and choose Save image as for an image wrapped in Zoom

Actual behavior

I could only save the page html

Steps to reproduce behavior

Use

<Zoom>
  <img src={source} />
</Zoom>
@rpearce
Copy link
Owner

rpearce commented Oct 16, 2020

@johanbook Thank you for reporting this. In the current version, there is a button covering the image. I will make sure this is not the case when I can circle back to the next version. #244 got put on hold because of some unavoidable issues that needed to be rethought, and we've just had a baby, so I'm not doing any coding at the moment.

@johanbook
Copy link
Author

Congratz to the baby @rpearce and thank you for this repo. If you point me in the right direction I make an attempt in creating a PR

@rpearce
Copy link
Owner

rpearce commented Oct 20, 2020

@johanbook It's unfotunately a bit more complicated than a simple PR, because the entire mechanism for "zooming" needs to change. THANK YOU for your offer of a PR, though.

@rpearce
Copy link
Owner

rpearce commented Mar 2, 2021

Similarly reported issue in #271. I'll track it here.

@rpearce
Copy link
Owner

rpearce commented Mar 28, 2021

Update on v5 FYI: #274

@rpearce
Copy link
Owner

rpearce commented Sep 8, 2021

FYI: I'm working on this right now and not as part of that rewrite.

@rpearce
Copy link
Owner

rpearce commented Nov 10, 2021

There was no way to do this in the current version without breaking things. Here's the latest update: #274 (comment)

@rpearce
Copy link
Owner

rpearce commented Jun 14, 2022

Here's the latest update about the work being done that will resolve this: #274 (reply in thread)

@rpearce
Copy link
Owner

rpearce commented Jul 25, 2022

If anyone finds some spare time and wants to give the latest build a whirl to try this out:

npm i --save react-medium-image-zoom@5.0.0-beta2.8

And, if you aren't already,

import Zoom from 'react-medium-image-zoom'
import 'react-medium-image-zoom/dist/styles.css'

// ... your other code

<Zoom>
  <MyImage />
</Zoom>

The updated v5-dev README is here, and there are some breaking changes to the extra options passed to be aware of, if you're using the options.

Thanks for your time!

@rpearce
Copy link
Owner

rpearce commented Aug 3, 2022

Should be closed now with the release of 5.0.0

@rpearce rpearce closed this as completed Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants