Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop subkey support from the internal OpenPGP parser #2281

Closed
wants to merge 1 commit into from

Conversation

pmatilai
Copy link
Member

@pmatilai pmatilai commented Nov 18, 2022

The world of OpenPGP subkeys is scarily complicated and we're failing at it in too many ways to count. People who need the complexity of a full implementation can use the Sequoia backend, meanwhile this tames the internal parser back to something we may be able to support.

Update tests accordingly - as a nice side-effect this makes the internal parser behave the same as Sequoia for these cases.

Fixes: #2278

@pmatilai
Copy link
Member Author

pmatilai commented Nov 18, 2022

@nwalfield and @DemiMarie if you have time to check this over I'd appreciate, not that we're in any hurry with this.
I haven't gone through it all in any sort of detail, this is just a simple chainsaw of the obvious subkey parts, there's probably more that we can simplify.

@pmatilai pmatilai force-pushed the nosubkey branch 2 times, most recently from 8ea3dd3 to 954a11e Compare November 18, 2022 11:17
The world of OpenPGP subkeys is scarily complicated and we're failing at
it in too many ways to count. People who need the complexity of a full
implementation can use the Sequoia backend, meanwhile this tames the
internal parser back to something we may be able to support.

Update tests accordingly - as a nice side-effect this makes the internal
parser behave the same as Sequoia for these cases.

Fixes: rpm-software-management#2278
@Conan-Kudo
Copy link
Member

This cannot be dropped, subkeys are used by a number of prominent users (including AlmaLinux). Dropping this will make it difficult for various build environments to use RPM to verify signatures.

@pmatilai
Copy link
Member Author

pmatilai commented Dec 7, 2022

Those who want subkeys get to use something else than the internal PGP parser. That is the point here.

@pmatilai
Copy link
Member Author

pmatilai commented Dec 7, 2022

In other words: the choice is not whether to keep subkey support in the internal parser or not. The choice is whether to keep the internal parser at all, and significantly reducing the complexity is the only way to keep it around for now.

@pmatilai
Copy link
Member Author

Closing temporarily, this needs a little more thought but also just to document the situation that we have zero pending PR's in the queue 😆 )

@pmatilai pmatilai closed this Jan 17, 2023
@pmatilai pmatilai deleted the nosubkey branch April 6, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup DRAGONS Here be dragons
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove subkey support from the internal OpenPGP parser
3 participants