Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.4.0 with custom template does not display tab contents on initial load #21

Closed
skidvd opened this issue Mar 26, 2015 · 3 comments
Closed

Comments

@skidvd
Copy link

skidvd commented Mar 26, 2015

I recently upgraded from 1.3.0 to 1.4.0 and starting encountering an issue where the default (first) tab contents are not displayed upon load. Once you start clicking in the tab headings all is fine. However, the initial load shows an empty tab.

Punk is here: http://plnkr.co/edit/wtTLfsaEppmlyDOAad0L

The same occurs when using the default template as well. This did not occur in 1.3.0.

@rpocklin
Copy link
Owner

Yep you're right. It's a breaking change, hence v1.4.0 - check the release notes on the homepage.

Reason is not everyone wanted it, if you want the old behaviour (ie. default to the first tab) then deep link the page that displays the tabs.

Currently the default tab is highlighted anyway, which is a bug in ui-bootstrap which is fixed in master but not released, for more info see angular-ui/bootstrap@91b5fb6

@skidvd
Copy link
Author

skidvd commented Mar 26, 2015

Doh! Sorry I missed that. Just curious, what motivated this change - seems like the defaulting (in the absence of a deep link) would be appropriate default?

@rpocklin
Copy link
Owner

It's in #16 but basically it's an assumption you always want to select the first tab. In certain cases though, you may want to show all unselected tabs and make the user choose which tab they want (which will happen once the above bug is fixed).

@skidvd skidvd closed this as completed Mar 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants