Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit events recorded at non-exits after 2c5a433060c23dde71aa462ad5e0ebb7e28afbfa #3909

Closed
khuey opened this issue Jan 28, 2025 · 1 comment
Closed

Comments

@khuey
Copy link
Collaborator

khuey commented Jan 28, 2025

I'm not quite sure what we're trying to do here, but this seems wrong:

{
  real_time:4900.766206 global_time:413, event:`SYSCALL: rrcall_detach_teleport' (state:ENTERING_SYSCALL)
 tid:1585678, ticks:126133
rax:0xffffffffffffffda rbx:0x681fffa0 rcx:0xffffffffffffffff rdx:0x0 rsi:0x0 rdi:0x0 rbp:0x681fffa0 rsp:0
x681ffe00 r8:0x0 r9:0x0 r10:0x0 r11:0x246 r12:0x182e13 r13:0x600d64f84eef r14:0x600d65503758 r15:0x776aae
aea040 rip:0x70000002 eflags:0x246 cs:0x33 ss:0x2b ds:0x0 es:0x0 fs:0x0 gs:0x0 orig_rax:0x3f1 fs_base:0x7
76aae85f740 gs_base:0x0
}
{
  real_time:4900.766219 global_time:414, event:`EXIT' tid:1585678, ticks:126133
}
{
  real_time:4900.818448 global_time:415, event:`SYSCALL: wait4' (state:EXITING_SYSCALL) tid:1585335, ticks:31044
rax:0x18320e rbx:0x681fffa0 rcx:0xffffffffffffffff rdx:0x0 rsi:0x7ffe7d7ec154 rdi:0x18320e rbp:0x681fffa0 rsp:0x681ffe00 r8:0x0 r9:0x7ffe7d7ebec1 r10:0x0 r11:0x246 r12:0x7ffe7d7ec718 r13:0x6430221aa289 r14:0x6430221acd68 r15:0x770059d72040 rip:0x70000002 eflags:0x246 cs:0x33 ss:0x2b ds:0x0 es:0x0 fs:0x0 gs:0x0 orig_rax:0x3d fs_base:0x770059cfd740 gs_base:0x0
  TraceTaskEvent::EXIT tid=1585678 status=0
  TraceTaskEvent::DETACH tid=1585678
  { tid:1585335, addr:0x7ffe7d7ec154, length:0x4 }
}

Why aren't the TraceTaskEvents on event 414 here?

The new EXIT event from 2c5a433 confuses the heck out of Pernosco.

@rocallahan rocallahan pinned this issue Jan 29, 2025
@rocallahan
Copy link
Collaborator

Recording an EXIT TaskTraceEvent was a mistake, I agree. All we really need to do to fix the bug I cared about is record the exit status in the threadgroup, which we were doing in conjunction with recording the EXIT TaskTraceEvent in other places, but we don't have to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants