Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subtitles/closed captions #104

Closed
AndrewRCD opened this issue Apr 13, 2024 · 9 comments
Closed

subtitles/closed captions #104

AndrewRCD opened this issue Apr 13, 2024 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@AndrewRCD
Copy link

I don't know if it is normal or not, so I am asking.
Can we add subtitles in multiple languages for the same video?
We can in the feed manager, but for some reason, when you build the SDK, it only shows the last entry.
If, for example, I add subs in EN, FR, and ES - on TV, it only shows the last entry, ES, and you don't have the option to select another sub.
If I change the order in the feed manager and add FR, ES, and EN, I can only see the EN sub.

With the upcoming update in October, when subs will be ..... well, kind of mandatory, I thought I try to see how it works :)

Thanks

@rrirower rrirower transferred this issue from rrirower/Channel-Feed-Manager Apr 14, 2024
@rrirower
Copy link
Owner

rrirower commented Apr 14, 2024

Can you post your feed file that contains more than one subtitle so that I can test?

@rrirower rrirower added the bug Something isn't working label Apr 14, 2024
@AndrewRCD
Copy link
Author

of course,
subtest.json

thank you

@rrirower
Copy link
Owner

Thanks, but, I need the actual url to the feed file.

@AndrewRCD
Copy link
Author

Ah, let me put it our somewhere - i just made this for you - i used it on a channel I have submitted since and obviously ii deleted all the extra subs to have it work properly.

@rrirower
Copy link
Owner

Ok, that will work. Having the url allows me to test while running the code.

@AndrewRCD
Copy link
Author

sorry, I should have thought of that ......
https://05.hosting-allsuper.info/tests/subs/subtest.json

thank you

@rrirower
Copy link
Owner

rrirower commented Apr 14, 2024

OK, I've identified the bug and have a fix for it. I'll have it in the next release.

@AndrewRCD
Copy link
Author

you are awesome, thanks.

@rrirower
Copy link
Owner

rrirower commented May 5, 2024

Resolved in 1.0.0.2.

@rrirower rrirower closed this as completed May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants