Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marvel example doesn't handle DioError in the UI #167

Closed
RobertBrunhage opened this issue Oct 1, 2020 · 3 comments
Closed

Marvel example doesn't handle DioError in the UI #167

RobertBrunhage opened this issue Oct 1, 2020 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@RobertBrunhage
Copy link
Contributor

Describe what scenario you think is uncovered by the existing examples/articles
In the home.dart file the .when error case doesn't handle DioError, for example doing this:

 if (err is DioError) {
      return Text(err.message);
 }

Describe why existing examples/articles do not cover this case
For now you are doing the following which will just print "Instance of..."

error: (err, stack) {
   return Scaffold(
     appBar: AppBar(title: const Text('Error')),
     body: Center(
       child: Text('$err'),
     )
  );
},
@RobertBrunhage RobertBrunhage added documentation Improvements or additions to documentation needs triage labels Oct 1, 2020
@rrousselGit rrousselGit self-assigned this May 10, 2023
@rrousselGit rrousselGit added the good first issue Good for newcomers label Oct 15, 2023
@msarkrish
Copy link
Contributor

Hi @rrousselGit , Can you assign this issue to me?

@rrousselGit
Copy link
Owner

Just raise a PR :)

@msarkrish
Copy link
Contributor

@rrousselGit I have raised a PR. I am waiting for your comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants