From 2346b43b3e643a8dc002231e760bbeeaf3533093 Mon Sep 17 00:00:00 2001 From: antedeguemon Date: Fri, 17 Nov 2023 01:31:36 -0500 Subject: [PATCH] Fixes unused function from Warning.MixEnv --- lib/credo/check/warning/mix_env.ex | 2 +- test/credo/check/warning/mix_env_test.exs | 14 ++++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/lib/credo/check/warning/mix_env.ex b/lib/credo/check/warning/mix_env.ex index 325b848ca..a0e943ad6 100644 --- a/lib/credo/check/warning/mix_env.ex +++ b/lib/credo/check/warning/mix_env.ex @@ -53,7 +53,7 @@ defmodule Credo.Check.Warning.MixEnv do for op <- @def_ops do # catch variables named e.g. `defp` - defp traverse({unquote(op), _, nil} = ast, issues, _issue_meta, _parens?) do + defp traverse({unquote(op), _, nil} = ast, issues, _issue_meta) do {ast, issues} end diff --git a/test/credo/check/warning/mix_env_test.exs b/test/credo/check/warning/mix_env_test.exs index 5c7005cb8..5a4af49b6 100644 --- a/test/credo/check/warning/mix_env_test.exs +++ b/test/credo/check/warning/mix_env_test.exs @@ -124,4 +124,18 @@ defmodule Credo.Check.Warning.MixEnvTest do |> run_check(@described_check) |> assert_issue() end + + test "it should report violations from variables named like def operations" do + """ + defmodule CredoSampleModule do + def some_function do + def = Mix.env() + defp = &Mix.env/0 + end + end + """ + |> to_source_file + |> run_check(@described_check) + |> assert_issues() + end end