Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Use custom stringified worker #1376

Open
1 task done
mydea opened this issue Dec 19, 2023 · 0 comments
Open
1 task done

[Feature Request]: Use custom stringified worker #1376

mydea opened this issue Dec 19, 2023 · 0 comments
Labels
feature request Things want to be added

Comments

@mydea
Copy link
Contributor

mydea commented Dec 19, 2023

Preflight Checklist

  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

What package is this feature request for?

rrweb

Problem Description

I noticed that for canvas recording, an base64 encoded inlined web worker is used. This is quite large in bundle size.

Proposed Solution

We could rewrite this to build a stringified web worker ourselves, like done in this PR: getsentry#144

If this sounds good to the core maintainers, I would port this PR over here as well?

Alternatives Considered

Keep it as base64 encoded (=larger, but a bit simpler setup)

Additional Information

We've been using such a stringified web worker in the Sentry SDK successfully for some time now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Things want to be added
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mydea